Search Issue Tracker

Fixed in 2019.3.X

Votes

6

Found in

2019.3.0a1

2019.3.0a10

Issue ID

1171344

Regression

Yes

[Regression ADB V1-V2] Focusing the Editor Window causes noticeable Slowdowns

Asset - Database

-

How to reproduce:
1. Open the project from Case 1108597
2. Open the Profiler window and profile the Editor
3. Focus another window(Notepad, Internet browser, another project, etc)
4. Re-focus the project window
5. Observe the Spike in the Profiler window caused by the AssetDatabase.Refresh

Expected result: Re-focusing the Editor does not cause a major slowdown
Actual result: Re-focusing the Editor does cause a noticeable slowdown

Reproducible with: 2019.3.0a1, 2019.3.0a11
Not reproducible with: 2017.4.31f1, 2018.4.5f1, 2019.1.13f1, 2019.2.0f1

  1. Resolution Note (fix version 2019.3):

    There are some potential fixes that are feasible but not really worth it for the speed up we could get:
    1. Jobify the Enumeration code -> This can halve the time it takes to enumerate using 4 jobs, so instead of 77ms, we would get 38ms refresh time
    2. Jobify the Categorize Assets code -> This could result in a decent speed up, so instead of 70ms we could bring it down to perhaps 10ms
    3. ImportAndPostProcessAssets currently there's no scheduled improvement for it, but we might be able to skip it completely if we detect there's no changes to scrips, settings & postprocessed assets.

    However, we have some work scheduled that could algoritmically change how this is done:
    1. Scan using Directory Monitor -> We would get the time down to 1ms
    2. Reverse dependency graph -> We would reduce the search space to not have to do an O(n) operation for assets, thus it nullifies the need to jobify the asset categorization code

    The jobification changes are not trivial, so that would block a programmer for a week or two, and that would prevent other high priority bugs from being fixed, so for now we will have to live with this slowdown while we implement the correct fixes for 2020.1

    Fixed in 2020.1.0a19

  2. Resolution Note (fix version 2019.3):

    Fixed in 2019.3.0f5

Comments (21)

  1. Vagabond_

    Aug 02, 2019 13:18

    This is indeed reproduceable in 2019.1 and 2019.2f1 as well. I reported this as well from within a 2019.2 b10 editor !

Add comment

Log in to post comment

All about bugs

View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.