Search Issue Tracker

Won't Fix

Votes

41

Found in

2022.3.16f1

2023.2.4f1

2023.3.0b1

Issue ID

UUM-59652

Regression

No

Crash on TransformAccessClearCallback when undoing ModularAvatar > Setup Outfit

--

-

Reproduction steps:
1. Open the attached project "ReproProj"
2. Open the “/Assets/scene.unity” Scene
3. Right-click “test“ GameObject (shapell > test)
4. Select ModularAvatar > Setup Outfit
5. Press CTRL + Z
6. Repeat steps 3 - 5

Expected result: Editor does not crash and continues to run
Actual result: Editor crashes

Reproducible with: 2022.3.16f1, 2023.2.4f1, 2023.3.0b1
Could not test with: 2021.3.33f1 (No ModularAvatar option)

Reproducible on: Windows 10 Enterprise 21H2
Not reproducible on: No other environment tested

Note:
- Modular Avatar is a 3rd party plugin

  1. Resolution Note:

    The crash in TransformAccessClearCallback comes from TransformAccess data that was saved into Undo being changed without updating the Undo System. This happens during a call to a user function called RebuildLock called after the undo data has been finalised. When attempting to undo, none of the relevant Transforms exist any more and clearing/applying the serialised data regarding those Transforms fails.

    Any code where new objects are created but not explicitly saved into the Undo System cannot be considered fully undoable. Additionally the Undo System cannot be expected to recover gracefully when the data it was provided is incomplete or incorrect, it is simply pointing to invalid memory once something changes without it being informed.

    In this case the constructor OnewayArmatureLock creates hundreds of unsaved Transforms and then baseBonesAccessor is switched to this list, making the TransformAccessArray data that was saved to the Undo System invalid.

    The crash described can be avoided by registering all the 'baseBone' Transforms using Undo.RegisterCreatedObjectUndo(baseBone, "") to ensure that the Transforms referred to in the TransformAccessArray contained in the Undo action still exist.

    Alternatively if the _baseBonesAccessor TransformAccessArray is disposed using _baseBonesAccessor.Dispose() before being directly overwritten the memory is cleared correctly and the Undo system is updated accordingly.

Comments (88)

  1. zarachloehazel

    Jul 25, 2024 00:35

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  2. zarachloehazel

    Jul 25, 2024 00:35

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  3. zarachloehazel

    Jul 25, 2024 00:35

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  4. zarachloehazel

    Jul 25, 2024 00:34

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  5. zarachloehazel

    Jul 25, 2024 00:34

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  6. zarachloehazel

    Jul 25, 2024 00:34

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  7. zarachloehazel

    Jul 25, 2024 00:33

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  8. zarachloehazel

    Jul 25, 2024 00:33

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  9. zarachloehazel

    Jul 25, 2024 00:33

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  10. zarachloehazel

    Jul 25, 2024 00:33

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

Add comment

Log in to post comment

All about bugs

View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.