Search Issue Tracker

Won't Fix

Votes

41

Found in

2022.3.16f1

2023.2.4f1

2023.3.0b1

Issue ID

UUM-59652

Regression

No

Crash on TransformAccessClearCallback when undoing ModularAvatar > Setup Outfit

--

-

Reproduction steps:
1. Open the attached project "ReproProj"
2. Open the “/Assets/scene.unity” Scene
3. Right-click “test“ GameObject (shapell > test)
4. Select ModularAvatar > Setup Outfit
5. Press CTRL + Z
6. Repeat steps 3 - 5

Expected result: Editor does not crash and continues to run
Actual result: Editor crashes

Reproducible with: 2022.3.16f1, 2023.2.4f1, 2023.3.0b1
Could not test with: 2021.3.33f1 (No ModularAvatar option)

Reproducible on: Windows 10 Enterprise 21H2
Not reproducible on: No other environment tested

Note:
- Modular Avatar is a 3rd party plugin

  1. Resolution Note:

    The crash in TransformAccessClearCallback comes from TransformAccess data that was saved into Undo being changed without updating the Undo System. This happens during a call to a user function called RebuildLock called after the undo data has been finalised. When attempting to undo, none of the relevant Transforms exist any more and clearing/applying the serialised data regarding those Transforms fails.

    Any code where new objects are created but not explicitly saved into the Undo System cannot be considered fully undoable. Additionally the Undo System cannot be expected to recover gracefully when the data it was provided is incomplete or incorrect, it is simply pointing to invalid memory once something changes without it being informed.

    In this case the constructor OnewayArmatureLock creates hundreds of unsaved Transforms and then baseBonesAccessor is switched to this list, making the TransformAccessArray data that was saved to the Undo System invalid.

    The crash described can be avoided by registering all the 'baseBone' Transforms using Undo.RegisterCreatedObjectUndo(baseBone, "") to ensure that the Transforms referred to in the TransformAccessArray contained in the Undo action still exist.

    Alternatively if the _baseBonesAccessor TransformAccessArray is disposed using _baseBonesAccessor.Dispose() before being directly overwritten the memory is cleared correctly and the Undo system is updated accordingly.

Comments (86)

  1. alicemcd00

    Jul 31, 2024 00:22

    I want to give all the praise to SKY NEST RECOVERY who not only recovered my lost Crypto Currency but also put me on the path of Cyber Security knowledge. Have you fallen prey to the Crypto Scam, online Romance Scam, Investment Scam, as I did? Through Crypto investments or sending money to scammers yourself? This is exactly where you need to be. I am Alice McDonald. I lost $195,300 AUD to a cryptocurrency investment scam Sky Nest Recovery Team helped me out. They are the best experts and efficient Cryptocurrency Recovery Solutions. I was scammed of a substantial amount of money after contacting several recovery agents for help but none could do anything for me, I wasted my time, and Sky Nest Recovery assisted me in the best of ways. They requested that I provide proof of conversation and payment with the phonies.

    I got help recovering all I had invested with these scammers after a frivolous battle with them because these scammers did everything possible to stop the efforts of SKY NEST RECOVERY from recovering my stolen money, they assured me that my funds would be recovered and they delivered their promise. A great big thanks to Sky Nest Recovery, your simplicity and competence can’t be overemphasized.

    Reach out to them if you need help in recovering your lost cryptocurrency. They are very fast and good at their job. contact them with the following information.

    Email: {skynestrecovery1(at)proton(dot)me} ,Telegram: {s k y n e s t r e c o v e r y}, WhatsApp: +1,3,0,5,9,8,0,9,4,9,9

  2. tomcrist491

    Jul 30, 2024 02:50

    If you have lost money investing in a fraudulent organization and feel that you should be reimbursed for your losses, you may want to pursue legal action. The organization, CIPHER BLADE, provides trustworthy services in the areas of money retrieval and scam company investigations. Their financial fraud specialists have years of expertise recovering monies from fraudulent businesses. They have a group of private investigators and attorneys at their disposal that can assist you get your money back by gathering proof in your favor. If you have already put money into a plan and you want your money back, you should get in touch with them as soon as possible. Contact them on their telegram:@cipherbladerecoveryltd

  3. zarachloehazel

    Jul 26, 2024 20:46

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  4. zarachloehazel

    Jul 26, 2024 20:46

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  5. zarachloehazel

    Jul 26, 2024 20:45

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  6. zarachloehazel

    Jul 26, 2024 20:45

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  7. zarachloehazel

    Jul 26, 2024 20:44

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  8. zarachloehazel

    Jul 25, 2024 00:36

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  9. zarachloehazel

    Jul 25, 2024 00:35

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

  10. zarachloehazel

    Jul 25, 2024 00:35

    CONTACT THE HACK ANGELS TO RECOVER ALL YOUR LOST CRYPTO/BTC ASSETS

    Please bear in mind that you must exercise caution and take precautions to protect yourself against future scams. One method to accomplish this is to be extremely cautious about the websites you visit and the links you click on. THE HACK ANGELS advised me to avoid disclosing personal or financial information to unfamiliar websites. It is also critical to utilize a secure Bitcoin wallet and keep your private keys protected. You can accomplish this by utilizing a hardware wallet or by keeping your private keys on a piece of paper in a secure location. If you have any queries or concerns about Bitcoin security and the recovery of lost assets, Please do not hesitate to ask THE HACK ANGELS. Reach out now.

    WHatsAP: +1 203,309,3359

Add comment

Log in to post comment

All about bugs

View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.